[java] Extract reaching definitions analysis out of UnusedAssignmentRule#3311
Merged
Conversation
This removes some noisyness that is better caught by unusedPrivateField
This uses the new dataflow and is in theory more precise, but also will report more things.
…-assignment-singular-field-that-kind-of-thing
…-assignment-singular-field-that-kind-of-thing
…ed-assignment-singular-field-that-kind-of-thing
Update AvoidThrowingNullPointerException
…-assignment-singular-field-that-kind-of-thing
…-assignment-singular-field-that-kind-of-thing
…-assignment-singular-field-that-kind-of-thing
Needs use-def chains...
…ngular-field-that-kind-of-thing
…ngular-field-that-kind-of-thing
…ngular-field-that-kind-of-thing
ConsecutiveLiteralAppendsRule mostly
…ngular-field-that-kind-of-thing
…ngular-field-that-kind-of-thing
…ngular-field-that-kind-of-thing
Generated by 🚫 Danger |
…ngular-field-that-kind-of-thing
adangel
approved these changes
Jun 25, 2021
adangel
left a comment
Member
There was a problem hiding this comment.
Thanks!
At some point, we should create unit tests for the dataflow implementation....
As far as I see, this PR
- fixes #1899
I'll add this to the release notes.
The other referenced missingbreakinswitch bugs are still open, I assume (at least, there are no test cases):
Then there is the renaming of "MissingBreakInSwitch" into "ImplicitSwitchFallThrough" (Problem 2 of #2894).
I'd suggest to make this a separate issue. Then we can rename it already in PMD 6 and remove the deprecated
rule reference in PMD 7.
Member
Ok, I tested them. You've fixed them already. |
Member
Author
|
Thanks for the review. |
adangel
added a commit
that referenced
this pull request
Jun 25, 2021
oowekyala:java-dfa-reaching-defs-unused-assignment-singular-field-that-kind-of-thing [java] Extract reaching definitions analysis out of UnusedAssignmentRule #3311
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
This way the data-flow information it collects can be used by more rules. This reimplements several rules using this information.
SingularField and ImmutableField should be more precise and more general. MissingBreakInSwitch is updated according to #2894, ie, its implementation strategy uses control flow information to detect fall-through, instead of blindly counting breaks. The remaining piece to fix this issue, is to rename the rule to "FallThroughSwitchCase".
Also part of these changes aim to reduce the importance of AbstractLombokAwareRule, by identifying the actual annotations that each rule should care about instead of just ignoring all lombok annotations for all those rules.
Related issues
Updates rules:
Ready?
./mvnw clean verifypasses (checked automatically by github actions)