[java] Fix NPE in MethodTypeResolution#3269
Merged
Merged
Conversation
Generated by 🚫 Danger |
oowekyala
approved these changes
May 9, 2021
oowekyala
left a comment
Member
There was a problem hiding this comment.
Thanks!
It has one big downside, though: We don't see these problems anymore.... (only indirectly maybe through false positives/false negatives)
It's still in the log though. I think this is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
In one of the last pmd regression reports, strange new errors appeared, e.g.
https://chunk.io/pmd/0263b81c16b8417b993b6ea93f55d7be/diff/spring-framework/index.html#section-errors
Also other exceptions occurred, e.g.
Other types seem to be missing, too: Type org.reactivestreams.Publisher not present, Type org.junit.runner.Runner not present, Type javax.servlet.http.Part not present, Type org.eclipse.jetty.websocket.api.extensions.ExtensionConfig not present.
So something seems to be wrong with the auxclasspath the pmd-regression-tester is using.
This PR does two things now:
It has one big downside, though: We don't see these problems anymore.... (only indirectly maybe through false positives/false negatives)
~/work/pmd/target/repositoriesas a cache directory. This contains the checkouts of pmd-regression-tester, e.g. the spring-framework. Now this has been cached, which means, we don't need to rebuild spring-framework again - but spring uses gradle... and gradle doesn't use the standard maven local repository cache. So I guess, the classpath.txt file created herepmd/.ci/files/project-list.xml
Line 92 in bf10745
pmd/.ci/files/project-list.xml
Line 38 in bf10745
Not a problem for checkstyle, because they use maven and ~/.m2/repository is already cached.
Oh, I also renamed the cache-key and restore-key to make sure, no old cache is used. Old caches are not complete and can't be used anymore.
Ready?
./mvnw clean verifypasses (checked automatically by github actions)