[java] Update rule PrematureDeclaration#3199
Merged
Merged
Conversation
Generated by 🚫 Danger |
This was
linked to
issues
Apr 10, 2021
adangel
approved these changes
Apr 16, 2021
adangel
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks!
One huge difference, as seen in the diff report, is that we don't report variables that are not used at all. Those are left to UnusedVariable.
This change makes total sense. I've created #3221 so that we can list this in the changelog.
adangel
added a commit
that referenced
this pull request
Apr 16, 2021
[java] Update rule PrematureDeclaration #3199
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
One huge difference, as seen in the diff report, is that we don't report variables that are not used at all. Those are left to UnusedVariable.
Related issues
The middle two means we now try to detect side-effects with some simple heuristics.
Ready?
./mvnw clean verifypasses (checked automatically by travis)