Skip to content

[java] Update rule UseStringBufferForStringAppends#3171

Merged
oowekyala merged 11 commits into
pmd:pmd/7.0.xfrom
adangel:pmd7-update-UseStringBufferForStringAppendsTest
Apr 4, 2021
Merged

[java] Update rule UseStringBufferForStringAppends#3171
oowekyala merged 11 commits into
pmd:pmd/7.0.xfrom
adangel:pmd7-update-UseStringBufferForStringAppendsTest

Conversation

@adangel

@adangel adangel commented Mar 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #2701

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.0.0 milestone Mar 26, 2021
@adangel adangel mentioned this pull request Mar 26, 2021
Closed
@ghost

ghost commented Mar 26, 2021 •
edited by ghost
Loading

Copy link
Copy Markdown
2 Messages
📖 Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 64 new violations, 0 new errors and 0 new configuration errors,
removes 22 violations, 0 errors and 0 configuration errors.
Full report
📖 Compared to master:
This changeset changes 2919 violations,
introduces 8091 new violations, 1 new errors and 0 new configuration errors,
removes 15645 violations, 10 errors and 2 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 66 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 0 violations,
introduces 28 new violations, 1 new errors and 0 new configuration errors,
removes 291083 violations, 10 errors and 2 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 66 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 0 violations,
introduces 28 new violations, 1 new errors and 0 new configuration errors,
removes 291076 violations, 10 errors and 2 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 90 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 0 violations,
introduces 52 new violations, 1 new errors and 0 new configuration errors,
removes 290876 violations, 10 errors and 2 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 68 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 0 violations,
introduces 32 new violations, 1 new errors and 0 new configuration errors,
removes 290877 violations, 10 errors and 2 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 729 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 0 violations,
introduces 693 new violations, 1 new errors and 0 new configuration errors,
removes 288384 violations, 10 errors and 2 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 729 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
[Full report](<html>

<title>504 Gateway Time-out</title>

504 Gateway Time-out

nginx

</html>/diff1/index.html)
✅ Compared to master:
This changeset changes 2334 violations,
introduces 6686 new violations, 1 new errors and 0 new configuration errors,
removes 15380 violations, 10 errors and 2 configuration errors.
[Full report](<html>

<title>504 Gateway Time-out</title>

504 Gateway Time-out

nginx

</html>/diff2/index.html)

Generated by 🚫 Danger

@oowekyala oowekyala self-assigned this Mar 28, 2021
@adangel adangel marked this pull request as draft March 30, 2021 17:16
@adangel

adangel commented Apr 2, 2021

Copy link
Copy Markdown
Member Author

I think, that's ready now.

@adangel adangel marked this pull request as ready for review April 2, 2021 09:50
oowekyala
oowekyala approved these changes Apr 3, 2021
View reviewed changes

@oowekyala oowekyala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll fix my comments while merging

Comment thread ...java/net/sourceforge/pmd/lang/java/rule/performance/UseStringBufferForStringAppendsRule.java Outdated
Comment thread ...java/net/sourceforge/pmd/lang/java/rule/performance/UseStringBufferForStringAppendsRule.java Outdated
@oowekyala oowekyala merged commit d264985 into pmd:pmd/7.0.x Apr 4, 2021
@adangel adangel deleted the pmd7-update-UseStringBufferForStringAppendsTest branch April 10, 2021 09:04
@adangel adangel mentioned this pull request Jan 10, 2023
Open
@adangel adangel mentioned this pull request Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oowekyala oowekyala oowekyala approved these changes

Assignees

@oowekyala oowekyala

Labels

None yet

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@adangel @oowekyala