Skip to content

[java] Update ForLoopCanBeForeach#3126

Merged
adangel merged 4 commits into
pmd:pmd/7.0.xfrom
oowekyala:reimplement-forloopcanbeforeach
Mar 26, 2021
Merged

[java] Update ForLoopCanBeForeach#3126
adangel merged 4 commits into
pmd:pmd/7.0.xfrom
oowekyala:reimplement-forloopcanbeforeach

Conversation

@oowekyala

@oowekyala oowekyala commented Feb 19, 2021 •
edited by adangel
Loading

Copy link
Copy Markdown
Member

Describe the PR

Update ForLoopCanBeForeach to pmd 7 grammar. There is one test that changed behavior, I think it's more regular that way. The rest of the changes in tests are to remove unresolved variables and types.

Related issues

Ready?

@oowekyala oowekyala added this to the 7.0.0 milestone Feb 19, 2021
@oowekyala oowekyala changed the title Update ForLoopCanBeForeach [java] Update ForLoopCanBeForeach Feb 19, 2021
@oowekyala oowekyala mentioned this pull request Feb 19, 2021
Closed
@ghost

ghost commented Feb 19, 2021 •
edited by ghost
Loading

Copy link
Copy Markdown
2 Messages
📖 Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 53 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
📖 Compared to master:
This changeset changes 2068 violations,
introduces 6048 new violations, 1 new errors and 0 new configuration errors,
removes 15174 violations, 10 errors and 2 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 53 new violations, 1 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 2068 violations,
introduces 6048 new violations, 2 new errors and 0 new configuration errors,
removes 15174 violations, 10 errors and 2 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 53 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 1 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 2068 violations,
introduces 6048 new violations, 1 new errors and 0 new configuration errors,
removes 15174 violations, 10 errors and 2 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 55 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 1 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 2068 violations,
introduces 6050 new violations, 1 new errors and 0 new configuration errors,
removes 15174 violations, 10 errors and 2 configuration errors.
Full report

Generated by 🚫 Danger

@oowekyala
Update ForLoopCanBeForeach
f07cc2c 
Remove unresolved things from tests
@oowekyala oowekyala force-pushed the reimplement-forloopcanbeforeach branch from afe5294 to f07cc2c Compare February 19, 2021 23:15
@oowekyala oowekyala marked this pull request as draft February 22, 2021 16:12
@oowekyala oowekyala linked an issue Mar 8, 2021 that may be closed by this pull request
[java] ForLoopCanBeForeach should consider iterating on this #833
Closed
@oowekyala oowekyala marked this pull request as ready for review March 8, 2021 16:36
@adangel adangel self-assigned this Mar 22, 2021
adangel
adangel approved these changes Mar 26, 2021
View reviewed changes

@adangel adangel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will merge in a moment

Comment thread pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/BinaryOp.java
Comment thread pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/internal/JavaRuleUtil.java
adangel added a commit that referenced this pull request Mar 26, 2021
@adangel
Merge pull request #3126 from oowekyala:reimplement-forloopcanbeforeach
a4ed281 
[java] Update ForLoopCanBeForeach #3126
@adangel adangel merged commit a71ad27 into pmd:pmd/7.0.x Mar 26, 2021
@oowekyala oowekyala deleted the reimplement-forloopcanbeforeach branch March 26, 2021 10:54
@adangel adangel mentioned this pull request Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adangel adangel adangel approved these changes

Assignees

@adangel adangel

Labels

None yet

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

[java] ForLoopCanBeForeach should consider iterating on this

2 participants

@oowekyala @adangel