[java] Update a few more rules in bestpractices#3116
Merged
Conversation
Do/while is now reported on the literal and not the 'do' keyword. This means violation lines will change.
Generated by 🚫 Danger |
adangel
approved these changes
Feb 19, 2021
| <test-code> | ||
| <description>#1217 SystemPrintln always says "System.out.print is used"</description> | ||
| <expected-problems>4</expected-problems> | ||
| <expected-messages> |
Member
There was a problem hiding this comment.
Since we have now anyway always the same message, this test case doesn't make sense anymore. Should we simply remove it?
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Feb 25, 2021
- protected and public members - refs pmd#3116
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
A small batch of 6 rules, see commit list
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)