[java] Usage resolution for java variables#3113
Merged
Merged
Conversation
This reverts commit 0cf084db5befb78579b05468014b3a26509d494a.
Generated by 🚫 Danger |
adangel
approved these changes
Feb 19, 2021
adangel
left a comment
Member
There was a problem hiding this comment.
Thanks, looks good! I'll merge it later today.
This was referenced Feb 19, 2021
This was
linked to
issues
Feb 19, 2021
adangel
added a commit
that referenced
this pull request
Feb 19, 2021
[java] Usage resolution for java variables #3113
This was referenced Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Reimplement variable usage resolution for Java in PMD 7. The implementation is trivial (see InternalApiBridge) as all the work is already done by the new symbol table. This brings the newer symbol table to feature parity with the old and allows porting more rules.
Related issues
Items of [java] Java-grammar progress document #2701
Related to [java] Merge unused declaration rules #2972
Fixes [java] UnusedLocalVariable: false-negative with array #2130
Fixes [java] UnusedPrivateMethod false positive with generics #2890
Fixes [java] UnusedPrivateMethod false positive from inner class via external class #1189
Fixes [java] UnusedPrivateMethod yields false positive for counter-variant arguments #770
Ready?
./mvnw clean verifypasses (checked automatically by travis)