Skip to content

[xml] Remove xml dom rule and parser options#2971

Merged
adangel merged 5 commits into
pmd:pmd/7.0.xfrom
oowekyala:remove-xml-dom-rule
Jan 24, 2021
Merged

[xml] Remove xml dom rule and parser options#2971
adangel merged 5 commits into
pmd:pmd/7.0.xfrom
oowekyala:remove-xml-dom-rule

Conversation

@oowekyala

@oowekyala oowekyala commented Dec 14, 2020

Copy link
Copy Markdown
Member

Describe the PR

  • Remove XML parser options, which now use their previous defaults
  • Remove the abstract XML visitor rule. It's not used, and it looks unnecessary. Why would one use a java visitor over XPath for an xml rule... Anyway if we want to support that in pmd 7, we should use the new AstVisitor interface, and I just don't see the point for now.

Existing parser tests for xml are converted to text comparison tests.

Related issues

Ready?

  • Deprecate AbstractWsdlRule, AbstractDomXmlRule on master
  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added this to the 7.0.0 milestone Dec 14, 2020
@ghost

ghost commented Dec 14, 2020

Copy link
Copy Markdown
1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

oowekyala added a commit to oowekyala/pmd that referenced this pull request Jan 17, 2021
@oowekyala oowekyala mentioned this pull request Jan 22, 2021
4 tasks
@adangel adangel merged commit a7230bc into pmd:pmd/7.0.x Jan 24, 2021
@oowekyala oowekyala deleted the remove-xml-dom-rule branch January 24, 2021 18:46
@adangel adangel added the is:feature-removal Remove an unneeded unused feature label Jan 13, 2023
@adangel adangel mentioned this pull request Jan 23, 2023
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is:feature-removal Remove an unneeded unused feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants