[java] Update UselessParentheses#2900
Merged
adangel merged 4 commits intoNov 6, 2020
Merged
Conversation
Generated by 🚫 Danger |
This was
linked to
issues
Nov 6, 2020
adangel
approved these changes
Nov 6, 2020
adangel
left a comment
Member
There was a problem hiding this comment.
I'll update the 7_0_0_release notes and merge....
adangel
added a commit
that referenced
this pull request
Nov 6, 2020
[java] Update UselessParentheses #2900
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Update UselessParentheses to pmd 7 grammar. I converted the rule to a java rule. The rule is more than 10 times faster than on master (from a quick & dirty run on checkstyle sources). I also included a property to ignore unnecessary parentheses that separate operators of different precedences, which gives a solution to #1918 and #1673 (this is the reason for the removed violations, they're actually fine).
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)