Skip to content

[java] Update many java rules#2899

Merged
oowekyala merged 183 commits into
pmd:pmd/7.0.xfrom
oowekyala:java-rule-bulk-update
Dec 10, 2020
Merged

[java] Update many java rules#2899
oowekyala merged 183 commits into
pmd:pmd/7.0.xfrom
oowekyala:java-rule-bulk-update

Conversation

@oowekyala

@oowekyala oowekyala commented Nov 4, 2020

Copy link
Copy Markdown
Member

Describe the PR

Update many (104) Java rules to pmd 7. There are still 179 of them

  • This introduces a few new xpath functions, which are documented.
  • Use a common utility class to share logic between rules (JavaRuleUtil), or to store procedures that are not really rule-specific
  • Some rule base classes have been removed. In particular, AbstractJunitRule is turned into JUnitRuleUtil TestFrameworksUtil
  • Some rules have been converted to XPath (which is why they're shown as deleted).
  • I tried not to change the definition of rules. I implemented [java] Remove special cases from rule EmptyCatchBlock #2893 though

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala marked this pull request as ready for review November 28, 2020 14:52
@oowekyala oowekyala self-assigned this Dec 10, 2020
@oowekyala oowekyala merged commit e73cc25 into pmd:pmd/7.0.x Dec 10, 2020
@oowekyala oowekyala deleted the java-rule-bulk-update branch December 10, 2020 19:48
This was referenced Dec 11, 2020
oowekyala added a commit that referenced this pull request Jan 3, 2022
has already been updated in #2899
@adangel adangel mentioned this pull request Jan 23, 2023
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment