[java] Update UnnecessaryFullyQualifiedName#2897
Merged
Merged
Conversation
Fix tests Doesn't work yet for static method calls: resolution of methods needs type resolution. Also fails with same package if classloader is not set
Generated by 🚫 Danger |
Member
Author
Fixed false positives:
Fixed false negatives:New false positives:New false negatives:
New errorsFixed messages:https://chunk.io/pmd/2a1eb68c5fe042b7ac1cebedab109e9c/diff2/checkstyle/index.html#A451 https://chunk.io/pmd/2a1eb68c5fe042b7ac1cebedab109e9c/diff2/spring-framework/index.html#A240 vs https://chunk.io/pmd/2a1eb68c5fe042b7ac1cebedab109e9c/diff2/spring-framework/index.html#A246 |
This was
linked to
issues
Nov 6, 2020
adangel
approved these changes
Nov 6, 2020
| if (name.equals(importDeclaration.getImportedName())) { | ||
| matches.add(importDeclaration); | ||
| continue; | ||
| JavaNode opa = next.getParent().getParent(); |
adangel
added a commit
that referenced
this pull request
Nov 6, 2020
[java] Update UnnecessaryFullyQualifiedName #2897
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Update rule UnnecessaryFullyQualifiedName. The rule uses the new symbol table, so it's much simpler. Hopefully it's also more precise. For method calls we err on the side of false-negatives instead of false positives. Let's see the regression report (though, messages have changed)
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)