Generated by 🚫 Danger

I think, we need to have a look at the regression tester again.
After we have now a baseline for pmd7 and you have activated this rule (ed01ddf), I expected to see a diff. But the regression tester still claimed "No java rules changed".... Maybe that's due to 5968877, where we changed from categories to individual rules...

That's one point I'd like to fix before merging.

But thinking further: The diff would then show, that we have possibly many new violations now, because we didn't have enabled the rule before. So we compare nothing again something....

I think, more interesting would be, if we compare the results against the latest pmd6 baseline. Then we would probably see more interesting results.... What do you think?

fixes #2797, so we should see more violations

I guess, that's worth listing in the release notes then.... 7_0_0_release_notes.md

@adangel Thanks for fixing the regression tester, this works well!

I've not seen false positives in MissingOverride. I found one for UnusedAssignment though: https://chunk.io/pmd/a580110b509440c2b5501fd1616a79be/diff2/checkstyle/index.html#A212 This should be fixed somewhere else.

So when this is merged, the CI will push the new baseline for pmd/7.0.x correctly? Or does this need other changes?

I've not seen false positives in MissingOverride.

Yeah, I only had a quick glance. But compared to master, this rule finds now many more cases. Good work!

I found one for UnusedAssignment though: https://chunk.io/pmd/a580110b509440c2b5501fd1616a79be/diff2/checkstyle/index.html#A212 This should be fixed somewhere else.

So when this is merged, the CI will push the new baseline for pmd/7.0.x correctly? Or does this need other changes?

I plan to merge the PRs for the regression tester and then use the master branch of the tester (currently using the PR-branch). I think, I'll cherry pick the relevant changes from this PR to pmd/7.0.x directly, so that it's available for the other PRs.

I'll double check, that the baseline can be created with the new pmdtester on pmd/7.0.x (I focused till now on the online mode, comparison with a baseline).

After that, I'll merge this PR.