Skip to content

[core] Deprecate report methods#2680

Merged
adangel merged 7 commits into
pmd:masterfrom
oowekyala:deprecate-report-methods
Aug 3, 2020
Merged

[core] Deprecate report methods#2680
adangel merged 7 commits into
pmd:masterfrom
oowekyala:deprecate-report-methods

Conversation

@oowekyala

@oowekyala oowekyala commented Jul 28, 2020

Copy link
Copy Markdown
Member

Describe the PR

Deprecate many methods of Report. This follows from #1962.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added the is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them label Jul 28, 2020
@oowekyala oowekyala added this to the 6.27.0 milestone Jul 28, 2020
@ghost

ghost commented Jul 28, 2020 •
edited by ghost
Loading

Copy link
Copy Markdown
1 Message
📖 This changeset introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ This changeset introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ This changeset introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@oowekyala oowekyala mentioned this pull request Jul 28, 2020
Merged
2 tasks
adangel
adangel reviewed Aug 2, 2020
View reviewed changes

@adangel adangel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved #1962 to 6.27.0 then....
Let me know, if you agree with my comments and whether you'll update the PR or whether I should do it.

Comment thread pmd-core/src/main/java/net/sourceforge/pmd/Report.java Outdated
Comment thread pmd-core/src/main/java/net/sourceforge/pmd/Report.java
Comment thread pmd-core/src/main/java/net/sourceforge/pmd/Report.java Outdated
Comment thread pmd-core/src/main/java/net/sourceforge/pmd/Report.java Outdated
Comment thread pmd-core/src/main/java/net/sourceforge/pmd/Report.java Outdated
@adangel adangel self-assigned this Aug 3, 2020
@adangel adangel mentioned this pull request Aug 3, 2020
Closed
adangel added a commit that referenced this pull request Aug 3, 2020
@adangel
Merge branch 'pr-2680'
621e6ac 
[core] Deprecate report methods #2680
@adangel adangel merged commit 709ec48 into pmd:master Aug 3, 2020
@oowekyala oowekyala deleted the deprecate-report-methods branch August 3, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adangel adangel adangel approved these changes

Assignees

@adangel adangel

Labels

is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them

Projects

None yet

Milestone

6.27.0

Development

Successfully merging this pull request may close these issues.

[core] Simplify Report API

2 participants

@oowekyala @adangel