[core] Deprecate parser options#2675
Merged
Merged
Conversation
There is no way to introduce the new API in a binary compatible change, so LVHandler::getDefaultParserOptions, LVHandler::getParser and Parser::parse will remain like this until 7.0 and be broken.
Someone may be using those properties, this would be a breaking change
Generated by 🚫 Danger |
adangel
approved these changes
Aug 2, 2020
adangel
left a comment
Member
There was a problem hiding this comment.
You comment about using different language versions instead of parser options might be the way to go.
Keeping parser options, means, we would produce different ASTs for the same language version, which is probably not good.
I'll merge this for 6.27.0
adangel
added a commit
that referenced
this pull request
Aug 2, 2020
[core] Deprecate parser options #2675
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
$title
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)