[all] Dependencies cleanup#2629
Merged
Merged
Conversation
Generated by 🚫 Danger |
This is for the scala modules. Apparently in the other order, only kotlin tests are run.
Member
|
I changed the scala pom because only the kotlin tests were being run: https://travis-ci.org/github/pmd/pmd/jobs/704446241#L6166-L6174 Only 2 other modules use both kotlin and java tests, for pmd-java both kinds were run, not so for pmd-modelica:
Edit: after the change, all tests are properly run: |
KroArtem
reviewed
Jul 13, 2020
KroArtem
left a comment
Contributor
There was a problem hiding this comment.
There are some dependencies that were purged. It's worth mentioning in Release notes because sometimes people rely on undeclared but used dependencies (like PMD does ;)) and it could be a surprise for them.
I don't count it as a review, just some remarks.
adangel
commented
Jul 16, 2020
adangel
added a commit
that referenced
this pull request
Jul 17, 2020
[all] Dependencies cleanup #2629
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
before
after
diff before/after
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)