[core] Deprecate missing language attribute on rule definition#2617
Merged
Conversation
Also, avoid parsing rulesets multiple times, otherwise the warning is duplicated
(name first)
2 tasks
Generated by 🚫 Danger |
adangel
approved these changes
Jul 30, 2020
adangel
left a comment
Member
There was a problem hiding this comment.
I do this simply by caching parsed rulesets in a RulesetFactory. Is this enough? I'm not sure
I think, that's good enough for now. If not, we can improve it later.
|
|
||
| ### API Changes | ||
|
|
||
| * In PMD 7, The `language` attribute will be required on all `rule` elements that |
Member
There was a problem hiding this comment.
I'll add the keyword "ruleset" - possibly as a section heading. Otherwise it is not clear, what we are talking about here...
Otherwise this is a good explanation, thanks!
adangel
added a commit
that referenced
this pull request
Jul 30, 2020
[core] Deprecate missing language attribute on rule definition #2617
This was referenced Aug 1, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Deprecate the practice of setting a rule's language in java rather than in the XML.
This also avoids parsing rulesets multiple times, otherwise the warning may be repeated. I do this simply by caching parsed rulesets in a RulesetFactory. Is this enough? I'm not sure
From #2612:
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)