[java] UseStringBufferForStringAppends: fix false negative with fields#2600
Merged
oowekyala merged 5 commits intoJun 21, 2020
Merged
Conversation
And also fix false positive when concatenation is local to each for-loop iteration. Test cases originally from pmd#1932 Author: jborgers <jborgers@jpinpoint.com>
This was referenced Jun 18, 2020
Generated by 🚫 Danger |
Fix false positives with field assignment and shadowing parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR fixes a false negative and a false positive of rule UseStringBufferForStringAppends:
for-loop iteration.
Test cases originally from #1932
Author: jborgers jborgers@jpinpoint.com
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)