[core] Deprecate Jaxen and XPath internal API #2407
Merged
Merged
Conversation
Defines properties
Generated by 🚫 Danger |
3 tasks
adangel
added a commit
that referenced
this pull request
Apr 13, 2020
adangel
added a commit
that referenced
this pull request
Apr 13, 2020
[core] Deprecate Jaxen and XPath internal API #2407
adangel
reviewed
Apr 13, 2020
| } | ||
|
|
||
| @Override | ||
| public void initialize(IndependentContext context) { |
Member
There was a problem hiding this comment.
Btw. this API must definitely change with PMD 7 - we are exposing here a implementation detail (that we use Saxon). And it happens, that the way, how custom functions are registered, changed with Saxon 9.5... which makes the need for a implementation agnostic API relevant...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1687
deprecated!, so they don't produce a warning in the XML, it's just their programmatic usage that is deprecated). Implementing these as properties was an easy solution, but they should not be overridden by users, as they're part of the implementation of the rule. Since we'll be giving a special XML syntax to XPath rules in 7.0, we won't need to implement these with properties anymore anyway