[apex] fixed WITH SECURITY_ENFORCED regex to recognise line break characters#2397
Merged
Conversation
Generated by 🚫 Danger |
Member
|
@kieranlblack Thanks for the PR! Would you mind adding a test case here: https://github.com/pmd/pmd/blob/master/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexCRUDViolation.xml ? |
adangel
added a commit
that referenced
this pull request
Apr 4, 2020
adangel
added a commit
that referenced
this pull request
Apr 4, 2020
[apex] fixed WITH SECURITY_ENFORCED regex to recognise line break characters #2397
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
Rule: ApexCrudViolation
Modified the regex used when checking if WITH SECURITY_ENFORCED is used to ensure it will account for any extra line break characters due to stylistic choices. Before, newlines would cause a false negative.
This continues to fix #2210