Skip to content

[jsp] Deprecate AST constructors and setters#2333

Merged
adangel merged 1 commit into
pmd:masterfrom
adangel:deprecate-jsp-ast
Mar 12, 2020
Merged

[jsp] Deprecate AST constructors and setters#2333
adangel merged 1 commit into
pmd:masterfrom
adangel:deprecate-jsp-ast

Conversation

@adangel

@adangel adangel commented Mar 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Also remove useless javadoc comments and fix license header

Prerequisite for #2294 , needed for #2239

@adangel
[jsp] Deprecate AST constructors and setters
ff7dfd9 
Also remove useless javadoc comments and fix license header
@adangel adangel added this to the 6.22.0 milestone Mar 5, 2020
@adangel adangel added is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them in:ast About the AST structure or API, the parsing step labels Mar 5, 2020
@ghost

ghost commented Mar 5, 2020

Copy link
Copy Markdown
1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

@adangel adangel removed the in:ast About the AST structure or API, the parsing step label Mar 5, 2020
oowekyala
oowekyala approved these changes Mar 9, 2020
View reviewed changes
Comment thread pmd-jsp/src/main/ant/alljavacc.xml
@adangel adangel self-assigned this Mar 12, 2020
@adangel adangel merged commit 9c65044 into pmd:master Mar 12, 2020
@adangel adangel deleted the deprecate-jsp-ast branch March 12, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oowekyala oowekyala oowekyala approved these changes

Assignees

@adangel adangel

Labels

is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them

Projects

None yet

Milestone

6.22.0

Development

Successfully merging this pull request may close these issues.

2 participants

@adangel @oowekyala