[vf, jsp] Adapt JSP & VF modules to new javacc wrapper#2294
Merged
Conversation
22 tasks
Generated by 🚫 Danger |
This was referenced Mar 5, 2020
adangel
reviewed
Mar 5, 2020
843832f to
affb046
Compare
adangel
approved these changes
Mar 19, 2020
adangel
left a comment
Member
There was a problem hiding this comment.
I'll merge that soon and take care of the setters, that can be made package-private.
I'll also remove the @Deprecated + @InternalApi annotations for the *TokenManager classes to have it consistent with the java language.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2239