[vm] Adapt VM module to the new javacc wrapper#2289
Merged
Conversation
Remove a bunch of useless copy pasted goo * LogUtil * TemplateParseException * MacroParseException * Many methods of AbstractVmNode Rename ASTprocess to ASTTemplate.
Generated by 🚫 Danger |
0907353 to
9983a52
Compare
22 tasks
adangel
reviewed
Feb 20, 2020
2 tasks
adangel
reviewed
Feb 20, 2020
…java Co-Authored-By: Andreas Dangel <andreas.dangel@pmd-code.org>
* remove directive mapper * remove all directive helper classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2211, part of #2239
This also renames ASTprocess to ASTTemplate, and removes a lot of dead code (though not nearly enough), including
#2176 is still on. I ported it to the new build just so it can't prevent other cross-language improvements by lagging behind