[java] Align method and constructor declaration grammar#2034
Merged
Conversation
…aration * Remove ASTConstructorDeclaration::getParameters -> use getFormalParameters * Remove ASTConstructorDeclaration::getParameterCount -> use getArity * Remove MethodDeclarator from MethodDeclaration grammar, deprecate node class * Add an ASTBlock to ASTConstructorDeclaration grammar and ASTMethodOrConstructorDeclaration::getBody * Remove ASTMethodDeclaration::getBlock in favour of getBody
Make JavaRuleViolation not depend on the old symbol table
Generated by 🚫 Danger |
adangel
reviewed
Sep 30, 2019
adangel
left a comment
Member
There was a problem hiding this comment.
Do we need to do the deprecations on master first?
Member
Which ones do you mean? |
Member
Author
ASTMethodDeclaration#getBlock -> getBody |
oowekyala
added a commit
that referenced
this pull request
Oct 5, 2019
Also, replace deprecated method usages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fleshes out ASTMethodOrConstructorDeclaration to abstract what can be abstracted, and align their grammar more closely
Grammar changes
API changes
Internal changes
TODO on master
JavaNode#getEnclosingTypeto masterAbstractJavaRule#getDeclaringTypeis useless, it only cares for class or interface types, it returns a simple string, even though the enclosing type may be anonymous...