[java,apex] Remove deprecated and unused rules#2022
Conversation
|
|
* AbstractNaming * AvoidFinalLocalVariable * AvoidPrefixingMethodParameters * ForLoopsMustUseBraces * IfElseStmtsMustUseBraces * IfStmtsMustUseBraces * MIsLeadingVariableName * SuspiciousConstantFieldName * WhileLoopsMustUseBraces
* UnsynchronizedStaticDateFormatter
* LoggerIsNotStaticFinal
|
At some point before releasing pmd 7, we need to delete the pmd 5 rulesets, which are all deprecated. |
|
Oh, and before actually deleting these "unlinked/unused" rules, we should collect them, if they sound useful, to have suggestions for new rules (see also https://github.com/pmd/pmd/wiki/Project-Ideas-%5BMature%5D#new-rules) - even if we don't implement them now. |
|
@adangel I think it's ok to remove rules that were not necessarily deprecated for 7.0.x. I think though, that it would be nice for rules that are not found to cause a warning instead of a ruleset parsing error. At the very least, we should collect all failures and present them all to the user instead of one by one. This will make version transitions smoother for the user |
Generated by 🚫 Danger |
This PR
This is just legacy code that makes it harder to do progress on other parts of 7.0.x (eg some of them use the old property constructors).