[java] Remove Name nodes in Import- and PackageDeclaration#1888
Merged
Conversation
Make ImportDeclaration not a TypeNode
21 tasks
adangel
reviewed
Jul 28, 2019
adangel
added a commit
that referenced
this pull request
Jul 28, 2019
adangel
added a commit
that referenced
this pull request
Jul 30, 2019
This was referenced Jan 16, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getPackageon ImportDeclaration. For the same reasons ImportDeclaration shouldn't be a TypeNode, getPackage is hard to define (it was defined as the Package of the type of ImportDeclaration). Besides, it was not used even once in our codebase and I think it's utterly useless. If you have the Class then you have the Package. This should be deprecated on masterSee https://github.com/pmd/pmd/wiki/Java_clean_changes#import-and-package-declarations