Skip to content

[core] Remove default implementation of getXPathNodeName#1826

Merged
oowekyala merged 3 commits into
pmd:pmd/7.0.xfrom
adangel:pmd7-abstract-node
May 18, 2019
Merged

[core] Remove default implementation of getXPathNodeName#1826
oowekyala merged 3 commits into
pmd:pmd/7.0.xfrom
adangel:pmd7-abstract-node

Conversation

@adangel

@adangel adangel commented May 11, 2019

Copy link
Copy Markdown
Member

Changes:

  • Ensures that a node has it's parent, when it is added as a child.
  • Makes getXPathNodeName() abstract by removing the default implementation.

Todo:

  • The default implementation of this method issued a warning. We have it mentioned in next_major_development.md, the we will remove it (under 6.1.0). Should we add it again (under 7.0.0?) that it has been removed?

@adangel adangel added this to the 7.0.0 milestone May 11, 2019
@ghost

ghost commented May 11, 2019

Copy link
Copy Markdown
1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

@adangel adangel mentioned this pull request May 13, 2019
Merged
@oowekyala oowekyala mentioned this pull request May 14, 2019
Merged
@oowekyala

oowekyala commented May 14, 2019

Copy link
Copy Markdown
Member

We have it mentioned in next_major_development.md, the we will remove it (under 6.1.0). Should we add it again (under 7.0.0?) that it has been removed?

I think it's ok to not repeat it, since it's in the javadocs too

@oowekyala

oowekyala commented May 14, 2019

Copy link
Copy Markdown
Member

@adangel I'm going to merge #1824 and this PR together sometime this week, I think they somewhat "balance" each other because of the change to the token setters.

@oowekyala oowekyala merged commit ef619af into pmd:pmd/7.0.x May 18, 2019
oowekyala added a commit that referenced this pull request May 18, 2019
@oowekyala
Merge branch 'pmd7-abstract-node' into 7.0.x
b56306c 
From PR #1826

* This PR is for PMD 7
* It's extracted from #1759

Changes:
* Ensures that a node has it's parent, when it is added as a child.
* Makes `getXPathNodeName()` abstract by removing the default
* implementation.
@adangel adangel deleted the pmd7-abstract-node branch May 26, 2019 10:29
@adangel adangel added the in:xpath Relating to xpath support at large, eg Jaxen / Saxon, custom functions, attribute resolution label Jan 12, 2023
@adangel adangel mentioned this pull request Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in:xpath Relating to xpath support at large, eg Jaxen / Saxon, custom functions, attribute resolution

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@adangel @oowekyala