[core] refactor: Make the children array never null#1823
Merged
Conversation
Generated by 🚫 Danger |
oowekyala
approved these changes
May 14, 2019
oowekyala
added a commit
that referenced
this pull request
May 18, 2019
From PR #1823 * This PR is for PMD 7. * It's extracted from #1759 Changes: * The children array in AbstractNode is now initialized with an empty * array. * This means, it is now never null, thus the null checks can be removed. * The only change to the children array is, when adding a new child * (`jjtAddChild`), or removing a child (`removeChildAtIndex`). Future: * the children array is protected. This means, sub classes could assign * null to it... do we really need field available in subclasses? I'd * assume, the already available methods are enough. -> this is something * for defining a general AST API (which methods should be package * private only, as they are only used by the parser, which methods * define the API, when do we implement iterator, etc..)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
jjtAddChild), or removing a child (removeChildAtIndex).Future: