[core,swift] Antlr Base Parser adapter and Swift Implementation#1698
Merged
Conversation
Generated by 🚫 Danger |
Member
|
I'd consider wrapping the exceptions in runtime exceptions that can abort the execution |
Member
|
Please, rebase this branch, as the PR with node changes is already merged. |
Member
|
@lsoncini @matifraga @tomidelucca this still needs to be rebased… |
02ad0f4 to
3469834
Compare
jsotuyod
reviewed
May 24, 2019
jsotuyod
reviewed
May 24, 2019
jsotuyod
approved these changes
May 24, 2019
adangel
added a commit
that referenced
this pull request
Jun 15, 2019
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request depends on #1658.
Before submitting a PR, please check that:
master. The PMD team will merge back to support branches as needed../mvnw clean verifypasses. This will build and test PMD, execute PMD and checkstyle rules. Check this for more infoPR Description:
We added an ant-file to make all Antlr4 autogenerated nodes extend
AntlrBaseNodefor swift, a base parser adapter for all Antlr4 autogenerated parsers and it's implementation for swift.Team Raptor.