Skip to content

[core] Fix JCommander help for -min option#1147

Merged
adangel merged 1 commit into
pmd:masterfrom
oowekyala:issue1145-minpriority-cli-option
May 26, 2018
Merged

[core] Fix JCommander help for -min option#1147
adangel merged 1 commit into
pmd:masterfrom
oowekyala:issue1145-minpriority-cli-option

Conversation

@oowekyala

Copy link
Copy Markdown
Member

Fix #1145

@oowekyala oowekyala added the is:low-impact Used for changesets that can be reviewed very quickly, e.g. because they're not user-facing. label May 25, 2018
@oowekyala oowekyala added this to the 6.4.0 milestone May 25, 2018
@adangel adangel self-assigned this May 26, 2018

@adangel adangel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}
}

// this has to be a public static class, so that JCommander can use it!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll move this comment up to the new RulePriorityValidator class when I merge it

@oowekyala oowekyala mentioned this pull request May 26, 2018
64 tasks
@adangel adangel merged commit c6367a8 into pmd:master May 26, 2018
adangel added a commit that referenced this pull request May 26, 2018
@oowekyala oowekyala deleted the issue1145-minpriority-cli-option branch May 26, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is:low-impact Used for changesets that can be reviewed very quickly, e.g. because they're not user-facing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants