Skip to content

[core] Log only once all messages#1045

Merged
adangel merged 2 commits into
pmd:masterfrom
jsotuyod:issue-1036
Apr 23, 2018
Merged

[core] Log only once all messages#1045
adangel merged 2 commits into
pmd:masterfrom
jsotuyod:issue-1036

Conversation

@jsotuyod

Copy link
Copy Markdown
Member

 - CLI runs log only to stderr, never to stdout
 - Both Ant and CLI runs log only once, the root logger never gets a
hold of the logs, completely isolating PMD
@jsotuyod jsotuyod added a:bug PMD crashes or fails to analyse a file. in:pmd-internals Affects PMD's internals is:waiting-for-review labels Apr 23, 2018
@jsotuyod jsotuyod added this to the 6.3.0 milestone Apr 23, 2018
@jsotuyod

Copy link
Copy Markdown
Member Author

Once merged, remember to add removing ConsoleLogHandler to #881

* @deprecated This class will be complety removed in 7.0.0
*/
@Deprecated
public class ConsoleLogHandler extends Handler {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the culprit was actually this class "ConsoleLogHandler", correct? Because it simply wrote to stdout...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct!

@adangel adangel self-assigned this Apr 23, 2018
@oowekyala oowekyala mentioned this pull request Apr 23, 2018
64 tasks
@adangel adangel merged commit 59bfc7a into pmd:master Apr 23, 2018
@jsotuyod jsotuyod deleted the issue-1036 branch April 23, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:bug PMD crashes or fails to analyse a file. in:pmd-internals Affects PMD's internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants