fix: set the default value of the dropdown as empty string#3563
Merged
Rom1-B merged 2 commits intopluginsGLPI:support/2.13.0from Feb 18, 2025
Merged
fix: set the default value of the dropdown as empty string#3563Rom1-B merged 2 commits intopluginsGLPI:support/2.13.0from
Rom1-B merged 2 commits intopluginsGLPI:support/2.13.0from
Conversation
stonebuzz
requested changes
Jan 29, 2025
Contributor
|
Can you adapt it and send it to the customer for validation? |
btry
reviewed
Jan 29, 2025
Author
|
The customer claims that the patch works |
Rom1-B
approved these changes
Feb 14, 2025
stonebuzz
approved these changes
Feb 14, 2025
btry
pushed a commit
that referenced
this pull request
Feb 27, 2025
* fix: set the default value of the dropdown as empty string * refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes description
the mandatory dropdown created with the plugin fields was not checked if the value was empty or not. In the database, the value could be a null value, an empty string or 0 and only the case where the value is equal to 0 is checked which validates the other two cases.
Checklist
Please check if your PR fulfills the following specifications:
References
#36030