Sync issues problem when a ticket has several validators#2959
Merged
btry merged 2 commits intopluginsGLPI:support/2.13.0from Oct 27, 2022
Merged
Conversation
9df13c0 to
628dfeb
Compare
f62e087 to
db8f75f
Compare
5a42dc4 to
4f26444
Compare
c77a8f3 to
5275bd4
Compare
if a ticket has several validators, the sync issue fails to recreate the row the HAVING COUNT() clause finds 2 rows instead of 1 The solution is to drop the user and group validators and find them dynamically with JOIN. this also allows to find all ticket validators
5275bd4 to
b5cb148
Compare
4721616 to
cb98a29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a ticket has several valodators, the sync issue fails to recreate the row
the HAVING COUNT() clause finds 2 rows instead of 1
The solution is to drop the validator user and validator group and find them dynamically with JOIN.
this also allows to find all ticket validators
Changes description
Remove users_id_validator and groups_id_validator from the issues table. As side effect, this allows to get several validators from a ticket, and (starting from GLPI 10.1) several validator groups from a ticket.
Checklist
Please check if your PR fulfills the following specifications:
References
Closes #N/A