Skip to content

plot.show() fix#129

Merged
mfreeborn merged 6 commits intoplotly:masterfrom
juanespj:jeplotly
Jan 9, 2023
Merged

plot.show() fix#129
mfreeborn merged 6 commits intoplotly:masterfrom
juanespj:jeplotly

Conversation

@juanespj
Copy link
Contributor

@juanespj juanespj commented Jan 8, 2023

Moved a few things around I got this to work on my Windows 10 machine seems like Spawn() does the trick!!

Moved a few things around I got this to work on my Windows 10 machine
seems like Spawn() does the trick!!
@mfreeborn
Copy link
Contributor

Thanks - but did you mean to make the code changes to the windows implementation? Looks like you edited the linux implementation by mistake!

@juanespj
Copy link
Contributor Author

juanespj commented Jan 8, 2023

Hey, yes it was supposed to be windows sorry, I had tested it on a offline copy
Do you want me to correct it?

@mfreeborn
Copy link
Contributor

mfreeborn commented Jan 8, 2023 via email

This reverts commit 780976a.
Hi, sorry for the last PR updated!!
@mfreeborn
Copy link
Contributor

Passing all the checks; that's good. One question though, what is the difference between the command start in the original code vs the /Cstart in this PR? I can only seem to find documentation about start, nothing really about the additional /C.

@juanespj
Copy link
Contributor Author

juanespj commented Jan 8, 2023

Passing all the checks; that's good. One question though, what is the difference between the command start in the original code vs the /Cstart in this PR? I can only seem to find documentation about start, nothing really about the additional /C.

the separate tags didn't make a difference on the original you had .split the message in args(), you also had the /C there, I am not sure why it is needed :(
I think the ones that made the difference are spawn() vs output().

@juanespj juanespj closed this Jan 8, 2023
@juanespj juanespj reopened this Jan 8, 2023
@mfreeborn
Copy link
Contributor

I found what /C is: https://stackoverflow.com/questions/515309/what-does-cmd-c-mean

I've just updated the file very slightly. Are you able to confirm that the latest commit (1818494) works on your computer? Then I can merge this.

@juanespj
Copy link
Contributor Author

juanespj commented Jan 9, 2023

Hey, that is a good find super clear now!! thank you for sharing...
just ran a couple of tests on my side all good to go! :)

@mfreeborn mfreeborn merged commit bec81a3 into plotly:master Jan 9, 2023
@mfreeborn
Copy link
Contributor

Great, thanks for that :) I'll release v0.8.4 with this fix once at least #126 is merged.

cohen990 pushed a commit to cohen990/plotly.rs that referenced this pull request Dec 12, 2025
* plot.show() fix

Moved a few things around I got this to work on my Windows 10 machine
seems like Spawn() does the trick!!

* Revert "plot.show() fix"

This reverts commit 780976a.

* fix plot.show() Windows

Hi, sorry for the last PR updated!!

* fix command line args

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Michael Freeborn <31806808+mfreeborn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants