Implement strict autotypenumbers by archmoj · Pull Request #5240 · plotly/plotly.js

archmoj · 2020-10-29T21:14:11Z

Fixes #5250 and,
Resolves #5195 by introducing two new attributes at layout and axis levels.

TODO:

add tests

@plotly/plotly_js

alexcjohnson · 2020-11-02T21:52:42Z

src/plots/cartesian/axis_autotype.js

-    if(linearOK(array)) return 'linear';
-    else return '-';
+    if(linearOK(array, convertNumeric)) return 'linear';
+    else return convertNumeric ? '-' : 'category';


I think it would be better to leave else return '-', for empty arrays and arrays with only null entries, and instead include convertNumeric in the category(array) call, ie replace:

else if(Lib.cleanNumber(ai) !== BADNUM) curvenums++;

with something like:

else if(convertNumeric ? Lib.cleanNumber(ai) !== BADNUM : typeof ai === 'number') curvenums++;

Good call. Done in b73d395.

src/plots/cartesian/layout_attributes.js

Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>

src/plots/layout_attributes.js

Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>

src/plots/layout_attributes.js

nicolaskruchten · 2020-11-03T14:25:17Z

OK so @alexcjohnson and I chatted about this and the attribute name should be autotypenumbers and it should be an enum with values "accept strings" or "strict", default value is "accept strings".

alexcjohnson · 2020-11-03T17:05:24Z

@archmoj pointed out just now that while we're at it here we could stop treating the number 2000 as a date for autotype purposes. Basically: as far as autotype is considered, in strict mode dates must be strings, numbers must be numbers, and categories must not be numbers.

I like this idea, and I think 'strict' is still a good value, but I think then we should change 'accept strings' to 'convert types' or 'cast types'.

nicolaskruchten · 2020-11-03T18:57:53Z

is it just the number 2000 or something like "integers below 3000" ?

alexcjohnson · 2020-11-03T19:16:14Z

I'd have to check exactly, but I believe it's at least all 4-digit integers, possibly also 2-digit integers.

archmoj · 2020-11-03T19:21:04Z

I'd have to check exactly, but I believe it's at least all 4-digit integers, possibly also 2-digit integers.

Also 2-digit integers: Demo.

…refactor

…r - and refactor

… & linear functions

src/plots/cartesian/axis_autotype.js

archmoj · 2020-11-04T15:41:37Z

@nicolaskruchten @alexcjohnson
This PR is now ready to review.
Thank you!

src/plots/layout_attributes.js

src/plots/ternary/layout_defaults.js

src/plots/polar/layout_defaults.js

src/traces/box/defaults.js

alexcjohnson

💃 💯

issue 5195 - implement convertnumeric for axes and inherit from layout

cbac3ae

archmoj added feature something new status: reviewable labels Oct 29, 2020

archmoj added this to the v1.58.0 milestone Oct 29, 2020

archmoj added 5 commits October 30, 2020 09:29

adjust autoType return when convertNumeric is disabled - add tests

c4224f4

fixups and add polar tests

3b1dd0f

add gl3d tests

48fabdd

add box plot tests an improve gl3d tests

5aca807

add tests for carpet

84907dc

alexcjohnson reviewed Nov 2, 2020

View reviewed changes

src/plots/cartesian/layout_attributes.js Outdated Show resolved Hide resolved

Update src/plots/cartesian/layout_attributes.js

04da8a1

Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>

alexcjohnson reviewed Nov 2, 2020

View reviewed changes

src/plots/layout_attributes.js Outdated Show resolved Hide resolved

Update src/plots/layout_attributes.js

01115cd

Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>

alexcjohnson reviewed Nov 2, 2020

View reviewed changes

src/plots/layout_attributes.js Outdated Show resolved Hide resolved

revise new attribute names and val types

fb67c82

archmoj changed the title ~~Implement convertnumeric for axes and inherit from layout.axesconvertnumeric~~ Implement strict autotypenumbers Nov 3, 2020

archmoj added 8 commits November 3, 2020 19:05

add early return for empty arrays to test category case and a bit of …

f1c0e31

…refactor

maintain detecting dates using strict mode

837761c

pass convertNumeric to linearOK and category

b73d395

store type of

0224fa0

add early return for dates - remove unnecessary early return in linea…

d218bab

…r - and refactor

add early returns - array of arrays is not relevant to date, category…

b800a65

… & linear functions

flat input array before passing to autoType functions

f6d8c39

revert description change

560405c

flat 2d arrays before passing to autotypes

4697f9c

alexcjohnson reviewed Nov 4, 2020

View reviewed changes

src/plots/cartesian/axis_autotype.js Show resolved Hide resolved

handle typed arrays inside a 2d array - plus a bit of optimization

688438c

archmoj added the bug something broken label Nov 4, 2020

add tests for autotype - case of 2d arrays

e02deaf

alexcjohnson reviewed Nov 4, 2020

View reviewed changes

src/plots/layout_attributes.js Outdated Show resolved Hide resolved

correct keys in description

4b5bfcc

alexcjohnson reviewed Nov 4, 2020

View reviewed changes

src/plots/ternary/layout_defaults.js Outdated Show resolved Hide resolved

alexcjohnson reviewed Nov 4, 2020

View reviewed changes

src/plots/polar/layout_defaults.js Show resolved Hide resolved

archmoj added 2 commits November 4, 2020 13:14

drop unused option in ternary

08aa300

add noMultiCategory option for polar

1198e56

archmoj commented Nov 4, 2020

View reviewed changes

src/traces/box/defaults.js Outdated Show resolved Hide resolved

alexcjohnson reviewed Nov 4, 2020

View reviewed changes

src/traces/box/defaults.js Outdated Show resolved Hide resolved

archmoj added 2 commits November 4, 2020 13:25

apply layout.calnedar and layout.autotypenumbers in box defaults

99a2015

fixup box plot test to have a layout object

6fdf559

alexcjohnson approved these changes Nov 4, 2020

View reviewed changes

archmoj merged commit 4e09ad3 into master Nov 4, 2020

archmoj deleted the disable-convertnumeric-in-autotype branch November 4, 2020 19:13

alexcjohnson mentioned this pull request Aug 3, 2021

Shapes are misplaced when using numbers as categoryarray values #5767

Open

archmoj mentioned this pull request Nov 24, 2021

Heat-map Error for Specific Data/Layout #6033

Closed

Uh oh!

Conversation

archmoj commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcjohnson Nov 2, 2020

Choose a reason for hiding this comment

Uh oh!

archmoj Nov 4, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicolaskruchten commented Nov 3, 2020

Uh oh!

alexcjohnson commented Nov 3, 2020

Uh oh!

nicolaskruchten commented Nov 3, 2020

Uh oh!

alexcjohnson commented Nov 3, 2020

Uh oh!

archmoj commented Nov 3, 2020

Uh oh!

Uh oh!

archmoj commented Nov 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexcjohnson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

archmoj commented Oct 29, 2020 •

edited

Loading