Merged
Conversation
alexcjohnson
approved these changes
Oct 26, 2020
Collaborator
alexcjohnson
left a comment
There was a problem hiding this comment.
Nice idea. I guess this would be hard to write a test for, so let's merge as is. 💃
|
hi, this bug yet not resolve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When encountering a webgl error, right now we invert the
is-mobiledetection to attempt creating the scene with differentpreserveDrawingBufferconfig second time. Although this helped solving the issues of some browsers and devices, it has a side-effect. Basically we won't notified by other webgl errors, if any. See #5222Therefore this PR limits this re-config attempt to the very first scene initialization in 94e98d7.
@plotly/plotly_js