This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Improve error message for invalid filter queries#758
Merged
Conversation
Marc-Andre-Rivet
approved these changes
Apr 21, 2020
Contributor
Marc-Andre-Rivet
left a comment
There was a problem hiding this comment.
💃 with a changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what it looks like now:
This PR improves this by:
=since there might be an=in the filter query itself, leading to an error message that has two=signs which is confusingDataTablefor specificity