This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Issue 618 - Keyboard navigation in sparsely readonly table#620
Merged
Marc-Andre-Rivet merged 5 commits intodevfrom Oct 9, 2019
Merged
Issue 618 - Keyboard navigation in sparsely readonly table#620Marc-Andre-Rivet merged 5 commits intodevfrom
Marc-Andre-Rivet merged 5 commits intodevfrom
Conversation
Marc-Andre-Rivet
commented
Oct 9, 2019
| return (<div | ||
| ref='el' | ||
| className={className} | ||
| tabIndex={-1} |
Contributor
Author
There was a problem hiding this comment.
this makes the element focusable
Collaborator
There was a problem hiding this comment.
neat, I didn't know about that
https://webaim.org/techniques/keyboard/tabindex
A tabindex="-1" value removes the element from the default navigation flow and also allows it to receive programmatic focus.
Seems like the right call (as opposed to 0, keeping it in the tab "navigation flow")
alexcjohnson
reviewed
Oct 9, 2019
| { | ||
| "name": "dash-table", | ||
| "version": "4.3.0", | ||
| "version": "4.4.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #618
New test, failure prior to fix: https://circleci.com/gh/plotly/dash-table/14271
Passes after fix: https://circleci.com/gh/plotly/dash-table/14278