This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Issue 598 - Permissive value in filter#599
Merged
Marc-Andre-Rivet merged 8 commits intodevfrom Sep 24, 2019
Merged
Conversation
| expect(tree.isValid).to.equal(true); | ||
| expect(tree.evaluate({ a: 'Hello world' })).to.equal(true); | ||
| expect(tree.evaluate({ a: 'Helloworld' })).to.equal(false); | ||
| }); |
Collaborator
There was a problem hiding this comment.
Can you include a toQueryString test for permissive as well?
alexcjohnson
approved these changes
Sep 24, 2019
Collaborator
alexcjohnson
left a comment
There was a problem hiding this comment.
Very nice - just two minor comments, then 💃
Co-Authored-By: alexcjohnson <johnson.alex.c@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#598
Allow more permissive expression value (with whitespaces without escaping or quotes) in column filters.
A limitation is that if it starts with an operator's text, the operator will be picked up instead. e.g
le jouris<= jour, not"le jour".Added a test case for permissive strings.
Added changelog entry.
#597
New
is blankunary operator that returns true forundefined,nulland''.In both cases, the documentation will need to be updated.