This repository was archived by the owner on Aug 29, 2025. It is now read-only.
change sorting_settings to sort_by#417
Merged
alexcjohnson merged 2 commits intomasterfrom Apr 25, 2019
Merged
Conversation
Member
|
💃 In the future, one idea to ease the transition for our users might be to keep the old prop type available in python but then raise a helpful error in the I'm OK doing a hard switch for now while we're still in alpha. Once this is merged, could you add a comment to #207? |
Collaborator
Author
Possibly - would be nice if there were some indication on the python side that you shouldn't use it. Maybe there's a way we could build "obsolete props" into
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed #412 (comment)