Merged
Conversation
hopefully these import changes will work on CI, they're needed for me to run locally
where props.className is applied
alexcjohnson
commented
Sep 2, 2021
| > | ||
| <span | ||
| id={id} | ||
| className={`hover-content ${props.className}`} |
Collaborator
Author
There was a problem hiding this comment.
Discovered while writing the test, but anyway users will expect props.id to be in the DOM. I put it on the content <span>, because this is where props.className is applied, and that's mostly where you probably want your styles applied. Makes it a little awkward to style the container, but because of the pseudo-elements making the triangle this is discouraged anyway, and we have special props for bg and border colors there already.
jonmmease
approved these changes
Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI I specifically did NOT commit build artifacts because @HammadTheOne is working on removing these from the repo entirely (oh there is is, #1734). AFAICT the tests all rebuild all the components anyway.
CHANGELOG.mdTooltipcomponent