Remove build artifacts and update build process#1734
Merged
HammadTheOne merged 17 commits intodevfrom Sep 1, 2021
Merged
Conversation
3 tasks
jonmmease
approved these changes
Aug 31, 2021
Contributor
jonmmease
left a comment
There was a problem hiding this comment.
I'll let @alexcjohnson give the final OK, but this looks good from my end.
Thanks @HammadTheOne!
alexcjohnson
approved these changes
Aug 31, 2021
Collaborator
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Love it! All sorts of good stuff here.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes build artifacts from the
devbranch ofdashand updates the build scripts. It also includes some cleanup for obsolete html components.Contributor Checklist
TODO
npm buildscript to build renderer and components.htmlcomponents.I have run the tests locally and they passed. (refer to testing section in contributing)
optionals
CHANGELOG.md