Merged
Conversation
| elif isinstance(arg_index_grouping, (tuple, list)): | ||
| func_args = list(args_grouping) | ||
| func_kwargs = dict() | ||
| func_kwargs = {} |
HammadTheOne
approved these changes
Aug 25, 2021
Contributor
HammadTheOne
left a comment
There was a problem hiding this comment.
💃
LGTM. One failing test, but it runs fine locally, so probably just a flaky run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Dash coming to .NET and MATLAB, these should be included in our default highlightjs config: F#, C#, MATLAB.
I also took the opportunity to update pylint to v2.10. I started looking at this because for some reason pylint thinks
multiprocess.Processisn't callable, and upgrading didn't fix that (surprised @jonmmease and others didn't hit this problem?) but it did introduce thedisable-nextsyntax which is really nice for avoiding long lines and strange line breaks as pylint and black fight with each other.A note: in #1679 we added the
dash/dcc,dash/html, anddash/dash_tabledirectories to.gitignore, but not until after their contents were committed. We should remove all of these files, and only commit them inmaster, but I'm not doing that here (and I'm committing the updated component bundles) so as not to further disrupt anyone else who depends on thedevbranch here right now.