Conversation
Dash.ly -> dash (same issue)
add `n_clicks` property to each component
… before 'import dash_html_components' (wrong-import-order). Standard import 'import sys as _sys' should be placed before 'import dash as _dash' (wrong-import-order).
… fix by changing the 'version' in version.py and then running from the command line: python3 setup.py --version
Replaced dash-core-components by dash-html-components
* Update generate-components to use prop-types for PropTypes (supporting React 16) Update components to use prop-types Move react (and react-dom) to peerDependencies to support multiple versions (15.4+ and 16.0+) Add package-lock.json * Update tests to include __init__ for finding tests package. * 0.8.1 * 0.9.0 * Bump version to 0.9.0 and update CHANGELOG * Remove mismatched components from previous release * Add back Base.react.js * integration tests * rerun publish * trigger ci build * Update generate-components to use prop-types for PropTypes (supporting React 16) Update components to use prop-types Move react (and react-dom) to peerDependencies to support multiple versions (15.4+ and 16.0+) Add package-lock.json * Update tests to include __init__ for finding tests package. * 0.8.1 * 0.9.0 * Bump version to 0.9.0 and update CHANGELOG * Remove mismatched components from previous release * Add back Base.react.js
…age if failed (#39) * add check that dash was imported and exit with useful message if not * don't add print_function to namespace * added test to check for sys.exit(1) when dash.py present
* Add data-* and aria-* attributes * added role attribute
* commit generated files to the repo - This is another sanity check for prerelease checks - Enables users to install directly from GitHub. For Python users, installing from PyPI is still the recommended way to install the package * let eslint ignore generated bundles
|
@alexcjohnson I added a However, while the workflow seems correct on CircleCI, we still have 6 jobs generated still on Percy, 2 of which have snapshots (looks like Could it be that we're using a somewhat older docker image for Percy which doesn't support this, rather than the recommended percy-agent CI orb? Or is it maybe the |
|
The slider dcc tests were failing because of an orjson encoding issue that's getting fixed in plotly/plotly.py#3351. |
|
I take it back, it's actually flaky locally 🤔 |
|
@alexcjohnson I split the dash-table ones which use percy storybook into a separate Percy build linked to the same repo, so they'll appear in the Github status, alongside the dash ones which would include dcc and html. The Dashboard Engine repo follows a similar pattern. If that looks fine, we can look at merging this PR tomorrow morning. |

This PR is the initial monorepo implementation. It integrates the
dash-core-components,dash-html-components, anddash-tablecomponent libraries and their dependencies within the Dash namespace, and adds some tools for maintaining the monorepo.dcc,html, anddash_tableto the Dash namespacedash-update-componentsto access and update packages within Dash.html,dccpackages.lerna import(must be done prior to merging the PR/updating components).Possibly mergedash-tabletodcc.test-appbefore merging.A test app is present at
test-app/test-dash.pyto check that imports and dependencies are successfully imported through Dash.Contributor Checklist
optionals
CHANGELOG.mdCloses plotly/dash-core#323