Skip to content

thet/navigationmarker/modernize Modernize, extend, simplify, document, test.#1565

Merged
petschki merged 10 commits intomasterfrom
thet/navigationmarker/modernize
Mar 23, 2026
Merged

thet/navigationmarker/modernize Modernize, extend, simplify, document, test.#1565
petschki merged 10 commits intomasterfrom
thet/navigationmarker/modernize

Conversation

@thet
Copy link
Copy Markdown
Member

@thet thet commented Mar 21, 2026 •
edited
Loading

Quite a lot of stuff, but mainly improvements. Non breaking, verified via the test suite added in #1559

In this PR (see individual commits):

  • Code modernization (class based patterns, patternslib options parser)
  • More parser arguments to set in-path and current classes and the selector for the item wrapper.
  • URL cleanup to better compare URLs and take out view names (if this is a controversial change we can later always bring that back in. e.g. if someone has links pointing to views in the navigation and really wants that to be marked...)
  • URL rebasing to better support relative/absolute URLs

Closes: #1217
Ref: #1509

@thet thet mentioned this pull request Mar 21, 2026
Closed
@thet thet force-pushed the thet/navigationmarker/modernize branch 3 times, most recently from 572555d to a0b7907 Compare March 21, 2026 12:38
thet added 8 commits March 21, 2026 13:51
@thet
feat(pat-navigationmarker): Modernize: class based Pattern, add optio…
3fa4c88 
…n portal-url, no jQuery.
@thet
feat(pat-navigationmarker): Also mark the anchor itself as current.
8c1e1cb
@thet
feat(pat-navigationmarker): Add in-path-class and current-class param…
83f3339 
…eters to customize the marker CSS classes.
@thet
feat(pat-navigationmarker): Make the nav item wrapper configurable.
55060ba
@thet
maint(pat-navigationmarker): Improve implementation.
c4890d6 
Simplify, clean up urls for better comparison, document functionality, etc.

Closes: #1217
@thet
feat(pat-navigationmarker): Rebase URLs to agains the portal URL.
fcb4c9c 
Closes: #1217
@thet
maint(pat-navigationmarker): Add roundtrip test from #1217.
40cd677 
Closes: #1217
@thet
maint(pat-navigationmarker): Rework tests to use direct pattern initi…
f21ded8 
…alization and await_pattern_init.
@thet thet force-pushed the thet/navigationmarker/modernize branch from a0b7907 to f21ded8 Compare March 21, 2026 12:51
@thet
feat(pat-navigationmarker): Add support for navigate event.
418b0c5 
Re-mark the navigation items when a location URL change has been happened resp. a  event was triggered.
@thet thet requested a review from petschki March 21, 2026 13:00
@thet thet mentioned this pull request Mar 21, 2026
Merged
@petschki
Merge pull request #1560 from plone/thet/navigationmarker/navigate
7aa9228 
pat-navigationmarker /w navigate event support
@petschki
Copy link
Copy Markdown
Member

petschki commented Mar 21, 2026

/run-coredev-robottests

petschki
petschki approved these changes Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and coredev robottests are green. I let you do the merge 👍🏼

@petschki petschki merged commit 62a050b into master Mar 23, 2026
3 checks passed
@petschki petschki deleted the thet/navigationmarker/modernize branch March 23, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petschki petschki petschki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thet @petschki