Skip to content

pat-navigationmarker /w navigate event support#1560

Merged
petschki merged 1 commit intothet/navigationmarker/modernizefrom
thet/navigationmarker/navigate
Mar 21, 2026
Merged

pat-navigationmarker /w navigate event support#1560
petschki merged 1 commit intothet/navigationmarker/modernizefrom
thet/navigationmarker/navigate

Conversation

@thet
Copy link
Copy Markdown
Member

@thet thet commented Mar 16, 2026

Refactoring, based on the tests added in #1559
And the modernisation branch: #1565

@thet thet marked this pull request as draft March 16, 2026 22:02
@thet thet changed the title pat-navigationmarker /w navigate support pat-navigationmarker /w navigate event support Mar 16, 2026
@thet thet force-pushed the thet/navigationmarker/navigate branch 2 times, most recently from 269735c to caee6b8 Compare March 20, 2026 09:58
Re-mark the navigation items when a location URL change has been happened resp. a  event was triggered.
@thet thet force-pushed the thet/navigationmarker/navigate branch from caee6b8 to 418b0c5 Compare March 21, 2026 16:24
@thet thet changed the base branch from master to thet/navigationmarker/modernize March 21, 2026 16:25
@thet thet marked this pull request as ready for review March 21, 2026 16:25
@thet thet requested a review from petschki March 21, 2026 16:25
@petschki petschki merged commit 7aa9228 into thet/navigationmarker/modernize Mar 21, 2026
3 checks passed
@petschki petschki deleted the thet/navigationmarker/navigate branch March 21, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants