chore: update dependencies and fix duplicate export warning#22
chore: update dependencies and fix duplicate export warning#22
Conversation
…mports - Add extendViteConfig import and configure optimizeDeps for @nuxt/content/slugify - Update deprecated @nuxt/content/nitro import to @nuxt/content/server - Remove duplicate nuxt-og-image module from modules array - Fix indentation in modules array for consistency This ensures the @pleaseai/docs layer works correctly when imported as a dependency in other Nuxt projects.
- Changed import from '@nuxt/content/server' to '@nuxt/content/nitro' in raw route handler - Matches Docus pattern for proper layer compatibility - Adds experimental.asyncContext flag to nuxt.config.ts - Updates compatibilityDate to 2025-07-22 - Applies ESLint formatting fixes (double quotes to single quotes) in UI components - Fixes indentation in apps/docs/nuxt.config.ts
- Update @nuxt/content from ^3.8.2 to ^3.9.0 - Update @nuxtjs/mdc from ^0.18.4 to ^0.19.1 - Update shadcn-nuxt from 2.3.3 to 2.4.3 - Update zod from ^3.25.76 to ^4.2.1 - Update tailwindcss and @tailwindcss/vite from ^4.1.17 to ^4.1.18 - Update other minor dependencies (@iconify-json/lucide, @nuxt/kit, nuxt-og-image, @nuxtjs/robots) - Rename flattenNavigation to flattenNavigationToSearchItems to fix duplicate export warning - Update AppSearch.vue to use renamed function - Update bun.lock with new dependency versions Closes #22
Summary of ChangesHello @amondnet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine maintenance task, bringing several core project dependencies up to date. It also addresses a specific code quality issue by renaming a function to eliminate a duplicate export warning. These changes collectively aim to improve the project's stability, leverage newer library features, and maintain a clean, warning-free codebase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Deploying docs-please with
|
| Latest commit: |
394d2e8
|
| Status: | 🚫 Deploy failed. |
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies to their latest versions and resolves a duplicate export warning by renaming a function. The changes are generally positive and improve the project's maintenance.
I have one specific suggestion regarding the nuxt.config.ts file in the packages/layer directory, where a package name is hardcoded. Making this dynamic would improve maintainability.
Additionally, I noticed the update of zod from v3 to v4. This is a major version bump, and while the tests pass, it's important to be mindful of potential breaking changes, especially since other parts of the workspace might still depend on v3 through other dependencies. Ensuring compatibility across the board is crucial.
Overall, this is a good set of updates.
| const includes = new Set(config.optimizeDeps.include) | ||
| includes.add('@nuxt/content > slugify') | ||
| config.optimizeDeps.include = Array.from(includes).map(id => | ||
| id.startsWith('@nuxt/content > ') ? `docs-please > ${id}` : id, |
There was a problem hiding this comment.
The package name docs-please is hardcoded here. This could be brittle if the package name is ever changed. Consider reading the package name from package.json dynamically to make this more robust.
Summary
Changes
Dependencies Updated
Files Modified
Test plan