[1.5.x] Scala 2.12.17 + Scala 2.13.10 + scala-xml 2.1.0#548
Conversation
|
We need this change in Caliban. See ghostdogpr/caliban#1472 error] stack trace is suppressed; run last play / update for the full output
[error] (play / update) found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error]
[error] * org.scala-lang.modules:scala-xml_2.12:2.1.0 (early-semver) is selected over 1.2.0
[error] +- org.scala-lang:scala-compiler:2.12.17 (depends on 2.1.0)
[error] +- com.typesafe.play:twirl-api_2.12:1.5.1 (depends on 1.2.0)
[error]
[error]
[error] this can be overridden using libraryDependencySchemes or evictionErrorLevelWhy is your PR a draft @mkurz? |
|
Because as long as there is no sbt 1.8 this pull request alone doesn't help. If I would merge that and release with a Play 2.8.x minor version lots of apps will break currently... If we have sbt 1.8 we could at least tell people to upgrade sbt in our release notes. |
|
@mkurz Thanks! 🙂 |
|
Just a heads up, now that sbt 1.8.0 is released. Is the plan to get this merged in and released? |
|
A |
|
This PR started before Travis was replaced with GH workflows. Needs a rebase. |
|
@ennru This pr is against the |
|
Thanks, @mkurz. I thought I had seen milestones, but than there was this PR... I believe we're good. |
|
@ennru I just tagged 1.6.0-RC1 which should be available on maven central soon. |
|
@ennru Ah and also be aware that the groupId changed from |
ca12482 to
974f8e6
Compare
|
The 1.5.x branch is quite outdated and still supports sbt 0.13.x so I had to apply some workarounds so we are able to pull in scala-xml 2.1.x (which causes problems with scala-js...), but I am almost there... Will push and merge later |
|
Pulling in scala-xml 2.x requires scala-js 1.x, but that isn't available for sbt 0.x anymore, so I had to find a workaround. I pushed all the changes that I think are necessary and good to go, published a snapshot and try to make use of it in playframework/playframework#11590, let's see |
|
So I can't really test this in playframework/playframework#11590 right now because we are stuck there for other reasons (see its comments). So the dependency tree looked like this before: Now it looks like this Given I tested this thoroughly I will merge and release 1.5.2 since it was requested by some users 😉 |
|
Oh and btw: I don't wanted to spend to much time with the 1.5.x branch anymore, so I didn't even bother to setup GitHub actions anymore, that's why I ran tests + will do the releases on my machine. In case we have to cut more 1.5.x releases I will take time to set up the GHA... |
|
twirl 1.5.2, with dependency to scala-xml 2.x is now released: https://github.com/playframework/twirl/releases/tag/1.5.2 |
This is probably needed if we want to upgrade the current Play 2.8.x branch with Scala 2.12.17