Skip to content

[2.8.x] sbt 1.8.0 compatibility#11590

Closed
mkurz wants to merge 7 commits into
playframework:2.8.xfrom
mkurz:sbt1.8-support
Closed

[2.8.x] sbt 1.8.0 compatibility#11590
mkurz wants to merge 7 commits into
playframework:2.8.xfrom
mkurz:sbt1.8-support

Conversation

@mkurz

@mkurz mkurz commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@mkurz mkurz added this to the 2.8.19 milestone Dec 20, 2022
@mkurz mkurz mentioned this pull request Dec 20, 2022
Merged
mkurz added 5 commits December 20, 2022 22:25
@mkurz
sbt 1.8.0 + compatible twirl release
077fa08
@mkurz
Scala 2.12.17
45fe379
@mkurz
Need to upgrade sbt-native-packager which pulls in scala-xml 2.x
6998ffa 
The problem is that version is not published for sbt 0.13 anymore,
so we need to conditionally pull in a older sbt-native-packer that
is still published for sbt 0.13
@mkurz
Add sonatype snapshots resolver
935237f
@mkurz
Temporary disable some workflow jobs
1e2d55e
@mkurz

mkurz commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Now all dependencies should pull in scala-xml 2.x.

However now we are blocked by

which makes it impossible to run scripted tests... Even if we make bgRun work, that doesn't help this pull request here, because bgRun is not available for sbt 0.13.x which Play 2.8.x still supports...

@mkurz

mkurz commented Dec 23, 2022

Copy link
Copy Markdown
Member Author

So I am thinking about what to do about sbt 1.8 for Play 2.8.x now... PlayNonBlockingInteractionMode is totally incompatible with sbt 1.8, at least I can not figure out a solution to the problem (there might be crazy hacks, but not sure if time invested in this pays of).
I will think about that a bit more, but maybe we just tell people to stay on sbt 1.7.2 for a while, I don't see an advantage of using sbt 1.8 for Play 2.8.x anyway.
People are free to upgrade to 1.8.x with the workaround to ignore the scala-xml errors anyway, but have to be aware that if they use PlayNonBlockingInteractionMode in their scripted tests, that wont work.

@mkurz mkurz modified the milestones: 2.8.19, 2.8.20 Jan 12, 2023
@mkurz mkurz modified the milestones: 2.8.20, 2.8.21 Jul 18, 2023
@mkurz mkurz removed this from the 2.8.21 milestone Sep 20, 2023
@mkurz

mkurz commented Sep 20, 2023

Copy link
Copy Markdown
Member Author

So there are workarounds to make Play 2.8 behave using sbt 1.7.3+, posted in #11522 and also see https://www.playframework.com/documentation/2.9.x/General#End-of-life-(EOL)-Dates.
I am not touching this anymore in 2.8.x since we would need to do major dependency upgrades, which I am not a fan of for 2.8.
Recommendation is to upgrade to Play 2.9 instead: https://github.com/playframework/playframework/releases/tag/2.9.0-RC2

@mkurz mkurz closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mkurz