Explicitly depend on netty-reactive-streams-http transitive dependencies#12403
Merged
mkurz merged 1 commit intoFeb 26, 2024
Conversation
Member
Author
|
@Mergifyio backport 2.9.x |
Contributor
✅ Backports have been createdDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids that we have to cut a new
netty-reactive-streams[-http]release each time we upgrade netty... which is a bit annoying... Also this approach here is a bit safer IMHO, in case we forget to cut a newnetty-reactive-streams[-http]release but upgrade netty in the dependencies only and ship mixed dependencies.netty-reactive-streams-httpdepends onnetty-reactive-streams: https://github.com/playframework/netty-reactive-streams/blob/netty-reactive-streams-parent-3.0.2/netty-reactive-streams-http/pom.xml#L17-L21netty-reactive-streams-httppulls innetty-codec-http: https://github.com/playframework/netty-reactive-streams/blob/netty-reactive-streams-parent-3.0.2/netty-reactive-streams-http/pom.xml#L22-L25netty-reactive-streamspulls innetty-handler: https://github.com/playframework/netty-reactive-streams/blob/netty-reactive-streams-parent-3.0.2/netty-reactive-streams/pom.xml#L17-L20I also checked locally running
show runtime:fullClasspathin sbt.