[2.8.x] Bugfix: Always set play.server.http.port, even if disabled#12256
Merged
Conversation
When runninng, within sbt: run disabled -Dhttps.port=9001 then the play.server.http.port config still is set to 9000, but should "disabled"
ihostage
approved these changes
Dec 6, 2023
Member
Author
|
@Mergifyio backport 2.9.x |
Contributor
✅ Backports have been createdDetails
|
Member
Author
|
@Mergifyio backport 3.0.x |
Member
Author
|
@Mergifyio backport main |
Contributor
❌ No backport have been createdDetails
GitHub error: |
Contributor
✅ Backports have been createdDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When runninng, within sbt:
then the play.server.http.port config still is set to 9000, but should "disabled"